Use first public parent for unresolvable Phabricator bases - #6828
Merged
olliehcrook merged 3 commits intoSep 24, 2026
Merged
Conversation
olliehcrook
marked this pull request as ready for review
September 14, 2026 10:20
olliehcrook
force-pushed
the
issue-6792-first-public-parent
branch
from
September 18, 2026 13:41
441e56f to
3a2a2a6
Compare
suhaibmujahid
approved these changes
Sep 23, 2026
suhaibmujahid
left a comment
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
Thank you! LGTM, just left some minor comments.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The fallback preserves existing behavior when metadata is absent and is adequately covered by focused tests.
Review effort: Balanced
Findings: None
What changed in this PR
Adds recovery for Phabricator revisions whose recorded base commit cannot be resolved.
Changes:
- Exposes
firstPublicParentfrom diff metadata. - Falls back to that parent when base resolution fails.
- Adds client and runtime coverage.
| File | Description |
|---|---|
libs/phabricator-client/phabricator_client/models.py |
Exposes first public parent metadata. |
libs/phabricator-client/tests/test_client.py |
Tests metadata extraction. |
libs/hackbot-runtime/hackbot_runtime/revision.py |
Adds base-resolution fallback. |
libs/hackbot-runtime/tests/test_revision.py |
Tests fallback behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Suhaib Mujahid <suhaibmujahid@gmail.com>
suhaibmujahid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6792 after moz-phab patch is rolled out.
Safe to add before - falls back to previous behaviour if first public commit is not present.
related: